zjcnb opened a new issue #12189:
URL: https://github.com/apache/shardingsphere/issues/12189
Hi community,
I found some code can be optimized, It 's about
```ShardingSphereDataSource```. For example:
```
ShardingSphereDataSource.createContextManager(final String schemaName, final
ModeConfiguration modeConfig)
ShardingSphereDataSource.createContextManagercreateContextManager(final
String schemaName, final ModeConfiguration modeConfig, final Map<String,
DataSource> dataSourceMap, final Collection<RuleConfiguration> ruleConfigs,
final Properties props)
```
I think these two methods can be merge one method, We only need to make
adjustments in the upper layer to be compatible.
Even, I think the two of them can be merged if we do not consider users to
directly create ShardingSphereDataSource
```
ShardingSphereDataSource(final String schemaName, final ModeConfiguration
modeConfig)
ShardingSphereDataSource(final String schemaName, final ModeConfiguration
modeConfig, final Map<String, DataSource> dataSourceMap, final
Collection<RuleConfiguration> ruleConfigs, final Properties props)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
