fwhdzh commented on issue #10968: URL: https://github.com/apache/shardingsphere/issues/10968#issuecomment-927133849
Hello. For the last three class. I find that ShardingTableMetaDataBuilder has haved its unit test. And I think ShardingSQLRewriteContextDecorator and ShardingParameterRewriterBuilder may have some problem since it looks like ShardingParameterRewriterBuilder.setUpParameterRewriters() has some "if" statement that will never be executed and ShardingSQLRewriteContextDecorator use ShardingParameterRewriterBuilder in its function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
