tristaZero commented on a change in pull request #12836:
URL: https://github.com/apache/shardingsphere/pull/12836#discussion_r719049043



##########
File path: README.md
##########
@@ -1,6 +1,6 @@
 # [ShardingSphere - Building a Criterion and Ecosystem Above Multi-Model 
Databases](https://shardingsphere.apache.org/)
 
-**Official Website:** 
[https://shardingsphere.apache.org/](https://shardingsphere.apache.org/)
+**Official Website:** [https://shardingsphere.apache.org/]()

Review comment:
       This is a markdown grammar. Your change will trigger a bad redirection.

##########
File path: README.md
##########
@@ -80,39 +76,28 @@ Apache ShardingSphere includes 3 independent products: 
JDBC, Proxy & Sidecar (Pl
 
 [![Maven 
Status](https://maven-badges.herokuapp.com/maven-central/org.apache.shardingsphere/shardingsphere-jdbc/badge.svg)](https://mvnrepository.com/artifact/org.apache.shardingsphere/shardingsphere-jdbc)
 
-ShardingSphere-JDBC is a lightweight Java framework providing extra services 
at the Java JDBC layer. With the client end connecting directly to the 
database, it provides services in the form of a jar and requires no extra 
deployment and dependence. It can be considered as an enhanced JDBC driver, 
fully compatible with JDBC and all kinds of ORM frameworks.
-Applicable in any ORM framework based on JDBC, such as JPA, Hibernate, 
Mybatis, Spring JDBC Template or direct use of JDBC. Supports any third-party 
database connection pool, such as DBCP, C3P0, BoneCP, Druid, HikariCP. Supports 
any kind of JDBC standard database: MySQL, Oracle, SQLServer, PostgreSQL and 
any SQL92 followed databases.
+A lightweight Java framework providing extra services at the Java JDBC layer. 
With the client end connecting directly to the database, it provides services 
in the form of a jar and requires no extra deployment and dependence. Supports 
any third-party database connection pool, such as DBCP, C3P0, BoneCP, Druid, 
HikariCP. Supports any kind of JDBC standard database: MySQL, Oracle, 
SQLServer, PostgreSQL and any SQL92 followed databases.
 
-![](./docs/document/content/Read-Me-Pics/Read-me-JDBC.png)
+For more details, follow this [link to the official 
website](https://shardingsphere.apache.org/document/current/en/overview/).

Review comment:
       
`https://shardingsphere.apache.org/document/current/en/overview/#shardingsphere-jdbc`
 may bring users to an exact position about JDBC, same with proxy.

##########
File path: README.md
##########
@@ -80,39 +76,28 @@ Apache ShardingSphere includes 3 independent products: 
JDBC, Proxy & Sidecar (Pl
 
 [![Maven 
Status](https://maven-badges.herokuapp.com/maven-central/org.apache.shardingsphere/shardingsphere-jdbc/badge.svg)](https://mvnrepository.com/artifact/org.apache.shardingsphere/shardingsphere-jdbc)
 
-ShardingSphere-JDBC is a lightweight Java framework providing extra services 
at the Java JDBC layer. With the client end connecting directly to the 
database, it provides services in the form of a jar and requires no extra 
deployment and dependence. It can be considered as an enhanced JDBC driver, 
fully compatible with JDBC and all kinds of ORM frameworks.
-Applicable in any ORM framework based on JDBC, such as JPA, Hibernate, 
Mybatis, Spring JDBC Template or direct use of JDBC. Supports any third-party 
database connection pool, such as DBCP, C3P0, BoneCP, Druid, HikariCP. Supports 
any kind of JDBC standard database: MySQL, Oracle, SQLServer, PostgreSQL and 
any SQL92 followed databases.
+A lightweight Java framework providing extra services at the Java JDBC layer. 
With the client end connecting directly to the database, it provides services 
in the form of a jar and requires no extra deployment and dependence. Supports 
any third-party database connection pool, such as DBCP, C3P0, BoneCP, Druid, 
HikariCP. Supports any kind of JDBC standard database: MySQL, Oracle, 
SQLServer, PostgreSQL and any SQL92 followed databases.
 
-![](./docs/document/content/Read-Me-Pics/Read-me-JDBC.png)
+For more details, follow this [link to the official 
website](https://shardingsphere.apache.org/document/current/en/overview/).
  
 ### ShardingSphere-Proxy
 
 
[![Download](https://img.shields.io/badge/release-download-orange.svg)](https://apache.org/dyn/closer.cgi?path=shardingsphere/5.0.0-beta/apache-shardingsphere-5.0.0-beta-shardingsphere-proxy-bin.tar.gz)
 [![Docker 
Pulls](https://img.shields.io/docker/pulls/apache/sharding-proxy.svg)](https://store.docker.com/community/images/apache/sharding-proxy)
 
-ShardingSphere-Proxy is a transparent database proxy, providing a database 
server that encapsulates database binary protocol to support heterogeneous 
languages. Friendlier to DBAs, the MySQL version now provided can use any kind 
of terminal (such as MySQL Command Client, MySQL Workbench, etc.) that is 
compatible with the MySQL protocol to operate data.
+A transparent database proxy, providing a database server that encapsulates 
database binary protocol to support heterogeneous languages. Friendlier to 
DBAs, the MySQL version now provided can use any kind of terminal (such as 
MySQL Command Client, MySQL Workbench, etc.) that is compatible with the MySQL 
protocol to operate data.
 It can be used directly as MySQL and PostgreSQL servers, and is applicable to 
any kind of terminal that is compatible with MySQL and PostgreSQL protocol.
 
-![](./docs/document/content/Read-Me-Pics/Read-me-proxy.png)
-
-
-|                         | *ShardingSphere-JDBC* | *ShardingSphere-Proxy* |
-| ----------------------- | --------------------- | ---------------------- |
-| Database                | Any                   | MySQL/PostgreSQL       |
-| Connections Count Cost  | High                  | Low                    |
-| Supported Languages     | Java Only             | Any                    |
-| Performance             | Low loss              | Relatively High loss   |
-| Decentralization        | Yes                   | No                     |
-| Static Entry            | No                    | Yes                    |
+For more details, follow this [link to the official 
website](https://shardingsphere.apache.org/document/current/en/overview/).
 
 
 ### Hybrid Architecture
 
-ShardingSphere-JDBC adopts a decentralized architecture, applicable to 
high-performance light-weight OLTP application developed with Java. 
ShardingSphere-Proxy provides static entry and all languages support, suitable 
for OLAP application and sharding databases management and operation.
+ShardingSphere-JDBC adopts a decentralized architecture, applicable to 
high-performance light-weight OLTP applications developed with Java. 
ShardingSphere-Proxy provides static entry and all languages support, suitable 
for OLAP application and sharding databases management and operation.
 
 Through the mixed use of ShardingSphere-JDBC & ShardingSphere-Proxy together 
with a unified sharding strategy by the same registry center, the 
ShardingSphere ecosystem can build an application system suitable to all kinds 
of scenarios.
 
-![](./docs/document/content/Read-Me-Pics/Read-me-hybrid.png)
+More details can be found following this [link to the official 
website](https://shardingsphere.apache.org/document/current/en/overview/).
 
 ## Roadmap:

Review comment:
       It is suggested to place `Solution` above `Roadmap` to connect closely 
to the products introduced above.

##########
File path: README.md
##########
@@ -9,13 +9,9 @@
 
[![Slack](https://img.shields.io/badge/%20Slack-ShardingSphere%20Channel-blueviolet)](https://join.slack.com/t/apacheshardingsphere/shared_invite/zt-sbdde7ie-SjDqo9~I4rYcR18bq0SYTg)
 
[![Gitter](https://badges.gitter.im/shardingsphere/shardingsphere.svg)](https://gitter.im/shardingsphere/Lobby)
 
-**Stargazers Over Time**
-
-[![Stargazers Over 
Time](https://starchart.cc/apache/shardingsphere.svg)](https://starchart.cc/apache/shardingsphere)
-
-**Contributors Over Time**
-
-[![Contributors Over 
Time](https://contributor-graph-api.apiseven.com/contributors-svg?chart=contributorOverTime&repo=apache/shardingsphere)](https://www.apiseven.com/en/contributor-graph?chart=contributorOverTime&repo=apache/shardingsphere)
+**Stargazers Over Time**           |  **Contributors Over Time**
+:---------------------------------:|:------------------------------------:
+[![Stargazers over 
time](https://starchart.cc/apache/shardingsphere.svg)](https://starchart.cc/apache/shardingsphere)
  |  [![Contributor over 
time](https://contributor-graph-api.apiseven.com/contributors-svg?chart=contributorOverTime&repo=apache/shardingsphere)](https://www.apiseven.com/en/contributor-graph?chart=contributorOverTime&repo=apache/shardingsphere)
 
 [![Build 
Status](https://api.travis-ci.org/apache/shardingsphere.svg?branch=master&status=created)](https://travis-ci.org/apache/shardingsphere)

Review comment:
       Why don't these badges show up together? e.g., `Gitter` and `buld 
status`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to