cheese8 opened a new issue #13508: URL: https://github.com/apache/shardingsphere/issues/13508
## Feature Request For now: 1、We see that there are two interfaces QueryAssistedEncryptAlgorithm and EncryptAlgorithm, QueryAssistedEncryptAlgorithm inherit from EncryptAlgorithm and provider method queryAssistedEncrypt for QueryAssist. 2、We see 5 fields in EncryptColumnRuleConfiguration but only one encryptorName can be configed with both QueryAssistedEncryptAlgorithm and EncryptAlgorithm, QueryAssistedEncryptAlgorithm was configed usually. 3、We see findEncryptor in EncryptRule.getEncryptValues and EncryptRule.getEncryptAssistedQueryValues, the methods in QueryAssistedEncryptAlgorithm only invoked during encrypt/queryAssistedEncrypt and decrypt, thinking of the above 2. That's a bad smell, so I consider merge QueryAssistedEncryptAlgorithm and EncryptAlgorithm into one called EncryptAlgorithm with 3 methods: encrypt, queryAssistedEncrypt and decrypt. Would you please suggest on this? @strongduanmu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
