TeslaCN commented on a change in pull request #13495:
URL: https://github.com/apache/shardingsphere/pull/13495#discussion_r745233339
##########
File path:
shardingsphere-proxy/shardingsphere-proxy-backend/src/test/java/org/apache/shardingsphere/proxy/backend/text/distsql/ral/common/set/executor/SetVariableExecutorTest.java
##########
@@ -40,7 +44,7 @@ public void assertExecuteWithTransactionType() {
BackendConnection connection = mock(BackendConnection.class);
when(connection.getTransactionStatus()).thenReturn(new
TransactionStatus(TransactionType.XA));
new SetVariableExecutor(statement, connection).execute();
- Assert.assertThat(TransactionType.LOCAL.name(),
is(connection.getTransactionStatus().getTransactionType().name()));
+ assertThat(TransactionType.LOCAL.name(),
is(connection.getTransactionStatus().getTransactionType().name()));
Review comment:
Actual value is on the left.
##########
File path:
shardingsphere-proxy/shardingsphere-proxy-backend/src/test/java/org/apache/shardingsphere/proxy/backend/text/distsql/ral/common/set/executor/SetVariableExecutorTest.java
##########
@@ -49,15 +53,20 @@ public void assertExecuteWithAgent() {
BackendConnection connection = mock(BackendConnection.class);
new SetVariableExecutor(statement, connection).execute();
String expectedValue =
SystemPropertyUtil.getSystemProperty(VariableEnum.AGENT_PLUGINS_ENABLED.name(),
"default");
- Assert.assertThat(expectedValue, is("false"));
+ assertThat(expectedValue, is("false"));
Review comment:
Maybe the `expectedValue` here and below should be named `actualValue`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
