linghengqian edited a comment on issue #15881: URL: https://github.com/apache/shardingsphere/issues/15881#issuecomment-1062406248
Actually, I thought about a similar solution. Referring to the processing ideas of https://github.com/baomidou/dynamic-datasource-spring-boot-starter , I think it is possible to add the global configuration `Map` of `hikaricp`, `dbcp` and `tomcat dbcp` under `spring.datasources.shardingsphere` (with these JDBC pool is used as an example because the source code of `shardingsphere` imports these three components as the implementation of the metadata spi). The data source instance can automatically extends these automatic configurations, and the configuration in the data source instance will override the globally configured JDBC pool properties. But the `shardingsphere proxy` is being retrofitted with `vert.x client`, which makes me wonder if it will be too complicated. ```yaml spring: datasource: dynamic: hikari: catalog: connection-timeout: validation-timeout: idle-timeout: leak-detection-threshold: max-lifetime: max-pool-size: min-idle: initialization-fail-timeout: connection-init-sql: connection-test-query: dataSource-class-name: dataSource-jndi-name: schema: transaction-isolation-name: is-auto-commit: is-read-only: is-isolate-internal-queries: is-register-mbeans: is-allow-pool-suspension: data-source-properties: health-check-properties: datasource: master: username: root password: 123456 driver-class-name: com.mysql.jdbc.Driver url: jdbc:mysql://xx.xx.xx.xx:3306/dynamic?characterEncoding=utf8&useSSL=false hikari: max-pool-size: idle-timeout: ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@shardingsphere.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
