zjcnb commented on code in PR #18465:
URL: https://github.com/apache/shardingsphere/pull/18465#discussion_r902149933
##########
shardingsphere-features/shardingsphere-db-discovery/shardingsphere-db-discovery-core/src/main/java/org/apache/shardingsphere/dbdiscovery/algorithm/DatabaseDiscoveryEngine.java:
##########
@@ -97,11 +98,26 @@ private Map<String, DataSource>
getActiveDataSourceMap(final Map<String, DataSou
}
return result;
}
-
- private void postReplicaDataSourceDisabledEvent(final String databaseName,
final String groupName, final String primaryDataSourceName, final Map<String,
DataSource> dataSourceMap) {
+
+ private void postReplicaDataSourceDisabledEvent(final String databaseName,
final String groupName, final String primaryDataSourceName,
+ final Map<String, DataSource> dataSourceMap, final
Collection<String> disabledDataSourceNames) {
+ int enabledReplicasCount = dataSourceMap.size() -
disabledDataSourceNames.size() - 1;
+
for (Entry<String, DataSource> entry : dataSourceMap.entrySet()) {
if (!entry.getKey().equals(primaryDataSourceName)) {
- ShardingSphereEventBus.getInstance().post(new
DataSourceDisabledEvent(databaseName, groupName, entry.getKey(),
createStorageNodeDataSource(loadReplicaStatus(entry.getValue()))));
+ StorageNodeDataSource storageNodeDataSource =
createStorageNodeDataSource(loadReplicaStatus(entry.getValue()));
+
+ if
(StorageNodeStatus.isEnable(storageNodeDataSource.getStatus())) {
+ enabledReplicasCount +=
disabledDataSourceNames.contains(entry.getKey()) ? 1 : 0;
+ ShardingSphereEventBus.getInstance().post(new
DataSourceDisabledEvent(databaseName, groupName, entry.getKey(),
storageNodeDataSource));
+ continue;
+ }
+
Review Comment:
Please remove extra blank line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
