linghengqian commented on code in PR #19878:
URL: https://github.com/apache/shardingsphere/pull/19878#discussion_r939505804
##########
shardingsphere-jdbc/shardingsphere-jdbc-core/src/test/java/org/apache/shardingsphere/driver/jdbc/core/statement/ReadwriteSplittingPreparedStatementTest.java:
##########
@@ -68,7 +68,6 @@ public void assertGetGeneratedKeys() throws SQLException {
int columnCount = generatedKeys.getMetaData().getColumnCount();
for (int index = 0; index < columnCount; index++) {
assertNotNull(generatedKeys.getObject(index + 1));
- assertNotNull(generatedKeys.getMetaData().getColumnLabel(index
+ 1));
Review Comment:
Refer to
https://github.com/apache/shardingsphere/pull/19878#issuecomment-1207174040.
##########
shardingsphere-jdbc/shardingsphere-jdbc-core/src/test/java/org/apache/shardingsphere/driver/jdbc/core/statement/ReadwriteSplittingPreparedStatementTest.java:
##########
@@ -88,7 +87,6 @@ public void assertGetGeneratedKeysWithPrimaryKeyIsNull()
throws SQLException {
int columnCount = generatedKeys.getMetaData().getColumnCount();
for (int index = 0; index < columnCount; index++) {
assertNotNull(generatedKeys.getObject(index + 1));
- assertNotNull(generatedKeys.getMetaData().getColumnLabel(index
+ 1));
Review Comment:
Refer to
https://github.com/apache/shardingsphere/pull/19878#issuecomment-1207174040.
##########
shardingsphere-jdbc/shardingsphere-jdbc-core/src/test/java/org/apache/shardingsphere/driver/jdbc/core/statement/ReadwriteSplittingStatementTest.java:
##########
@@ -53,7 +53,6 @@ public void assertGetGeneratedKeys() throws SQLException {
int columnCount = generatedKeys.getMetaData().getColumnCount();
for (int index = 0; index < columnCount; index++) {
assertNotNull(generatedKeys.getObject(index + 1));
- assertNotNull(generatedKeys.getMetaData().getColumnLabel(index
+ 1));
Review Comment:
Refer to
https://github.com/apache/shardingsphere/pull/19878#issuecomment-1207174040.
##########
shardingsphere-jdbc/shardingsphere-jdbc-core/src/test/java/org/apache/shardingsphere/driver/jdbc/core/statement/ShardingSphereStatementTest.java:
##########
@@ -58,7 +58,6 @@ public void assertGetGeneratedKeys() throws SQLException {
generatedKeysResultSet = statement.getGeneratedKeys();
assertTrue(generatedKeysResultSet.next());
assertThat(generatedKeysResultSet.getLong(1), is(6L));
- assertFalse(statement.execute(String.format(sql, 1, 1, "init"),
new String[]{"no"}));
Review Comment:
Refer to
https://github.com/apache/shardingsphere/pull/19878#issuecomment-1207174040.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
