shanrenxj commented on PR #20008: URL: https://github.com/apache/shardingsphere/pull/20008#issuecomment-1209392202
> > > > * What do you think of [use src 11 for tool, but 8 for plugin/runtime antlr/antlr4#3450](https://github.com/antlr/antlr4/pull/3450)? > > > > * Does ShardingSphere have to do this too? At least JDK8 compatibility must be guaranteed before the Minor Version changes. > > > > > > > > > > > > * I pointed out a fun PR. Although `maven.compiler.source` and `maven.compiler.target` are set to 11, the release of `maven-compiler-plugin` for all subprojects is 8. This is also why the ShardingSphere project can use Groovy 4.0.3, even though the master branch of Groovy requires JDK 16 builds. > > > > > > It seems that shardingsphere needs to do the same > > I don't think so. I'm currently working on some other PR preparations, so I can't test my ideas right away. If you think there are some easy ideas to deal with it, it's a good idea to submit a new commit to be verified by CI. As the project is in a hurry, our team currently uses hibernate core: 6.0.0 (ANTLR 4.9.1) to avoid ANTLR conflicts. Looking forward to shardingsphere update, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
