babynata opened a new issue #2113:
URL: https://github.com/apache/incubator-shenyu/issues/2113


   ### Is there an existing issue for this?
   
   - [X] I have searched the existing issues
   
   ### Current Behavior
   
   Because the docker plugin was specified as the regular build plugin, every 
time when the examples module is built, the docker will be triggered which may 
cause the failure of the install process.
   
   Example before fixing:
   
   > <build>
   >    ...
   >       <plugins>
   >          <plugin>
   >                 <groupId>com.spotify</groupId>
   >                 <artifactId>dockerfile-maven-plugin</artifactId>
   >                 <version>1.4.6</version>
   >                 <executions>
   >                     <execution>
   >                         <id>shenyu-examples-grpc</id>
   >                         <goals>
   >                             <goal>build</goal>
   >                         </goals>
   >                     </execution>
   >                 </executions>
   >                 <configuration>
   >                     <repository>shenyu-examples-grpc</repository>
   >                     <tag>latest</tag>
   >                     <buildArgs>
   >                         <APP_NAME>shenyu-examples-grpc</APP_NAME>
   >                     </buildArgs>
   >                 </configuration>
   >             </plugin>
   >    </plugins>
   > </build>
   
   ### Expected Behavior
   
   The docker plugin should only be triggered when it was declared as a 
parameter during the docker compose, which means it is an alternative process.
   
   Like this:
   
   >     <profiles>
   >         <profile>
   >             <id>docker</id>
   >             <activation>
   >                 <activeByDefault>false</activeByDefault>
   >             </activation>
   >             <build>
   >                 <plugins>
   >                     <plugin>
   >                         <groupId>com.spotify</groupId>
   >                         <artifactId>dockerfile-maven-plugin</artifactId>
   >                         <version>1.4.6</version>
   >                         <executions>
   >                             <execution>
   >                                 <id>shenyu-examples-grpc</id>
   >                                 <goals>
   >                                     <goal>build</goal>
   >                                 </goals>
   >                             </execution>
   >                         </executions>
   >                         <configuration>
   >                             <repository>shenyu-examples-grpc</repository>
   >                             <tag>latest</tag>
   >                             <buildArgs>
   >                                 <APP_NAME>shenyu-examples-grpc</APP_NAME>
   >                             </buildArgs>
   >                         </configuration>
   >                     </plugin>
   >                 </plugins>
   >             </build>
   >         </profile>
   >     </profiles>
   
   ### Steps To Reproduce
   
   run the docker compose with current setting
   
   ### Environment
   
   ```markdown
   ShenYu version(s):2.4.0
   ```
   
   
   ### Debug logs
   
   TODO
   
   ### Anything else?
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to