dragon-zhang commented on pull request #2815:
URL:
https://github.com/apache/incubator-shenyu/pull/2815#issuecomment-1022910531
I found everything goes well, the old version of
`org.dromara.soul.web.filter.CrossFilter` simply add the http header.
```java
public class CrossFilter implements WebFilter {
//......
@Override
@SuppressWarnings("all")
public Mono<Void> filter(final ServerWebExchange exchange, final
WebFilterChain chain) {
ServerHttpRequest request = exchange.getRequest();
if (CorsUtils.isCorsRequest(request)) {
ServerHttpResponse response = exchange.getResponse();
HttpHeaders headers = response.getHeaders();
headers.add("Access-Control-Allow-Origin", ALLOWED_ORIGIN);
headers.add("Access-Control-Allow-Methods", ALLOWED_METHODS);
headers.add("Access-Control-Max-Age", MAX_AGE);
headers.add("Access-Control-Allow-Headers", ALLOWED_HEADERS);
headers.add("Access-Control-Expose-Headers", ALLOWED_EXPOSE);
headers.add("Access-Control-Allow-Credentials", "true");
if (request.getMethod() == HttpMethod.OPTIONS) {
response.setStatusCode(HttpStatus.OK);
return Mono.empty();
}
}
return chain.filter(exchange);
}
}
```
And in `org.apache.shenyu.web.filter.CrossFilter`, it has been processed for
the same request header by `filterSameHeader`.
```java
/**
* Filter the same headers.
*
* @param headers the response headers
* @param header header name
* @param newHeaderValue the new value for header
*/
private void filterSameHeader(final HttpHeaders headers, final String
header, final String newHeaderValue) {
if (StringUtils.isBlank(newHeaderValue)) {
return;
}
if (ALL.equals(newHeaderValue.trim())) {
headers.set(header, ALL);
return;
}
final Set<String> newHeaders = Stream.of(newHeaderValue.split(","))
.map(String::trim).collect(Collectors.toSet());
List<String> originHeaders = headers.get(header);
if (CollectionUtils.isNotEmpty(originHeaders)) {
if (originHeaders.contains(ALL)) {
return;
}
originHeaders = Stream.of(String.join(",",
originHeaders).split(","))
.map(String::trim).collect(Collectors.toList());
newHeaders.addAll(originHeaders);
}
headers.set(header, String.join(",", newHeaders));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
