kerwin612 commented on code in PR #450:
URL: https://github.com/apache/shenyu-dashboard/pull/450#discussion_r1616619922
##########
src/index.ejs:
##########
@@ -27,7 +27,7 @@
</head>
<body>
- <div id="httpPath" style="display: none"
th:text="<%='$'%>{domain}">${process.env.NODE_ENV === 'production' ? '' :
'http://localhost:9095'}</div>
+ <div id="httpPath" style="display: none"
th:text="<%='$'%>{domain}">${process.env.NODE_ENV === 'production' ? '' :
'.'}</div>
Review Comment:
Because there are already dev-http-path here:
https://github.com/apache/shenyu-dashboard/blob/37763d94d06077f1170768980978da531546f328/.webpackrc.js#L50
For the convenience of unified maintenance, the same configuration for the
same target should be reduced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
