VampireAchao opened a new pull request, #5622:
URL: https://github.com/apache/shenyu/pull/5622
<!-- Describe your PR here; e.g. Fixes #issueNo -->
Fixes #5621
Fixes the issue where the plugin edit page fails to load due to an incorrect
query in the `GET /namespacePlugin/id={id}&namespaceId={namespaceId}` endpoint.
The query used `pluginId = {id}`, which resulted in no data being returned.
**Changes Made:**
- **Refactored**:
`org.apache.shenyu.admin.service.NamespacePluginService#findById` to
`findByPluginId`.
- **Updated**: The frontend request for "namespacePlugin/fetchItem" to use
`pluginId` instead of `id`.
- **Modified**: The `plugin_id` field in the `plugin_ns_rel` table from a
numeric type to `VARCHAR(128)` to prevent type mismatch errors.
- **Updated**:
`org.apache.shenyu.admin.mapper.NamespacePluginRelMapper#existed` to align with
the changes in how plugin IDs are handled.
Note that bulk operations such as delete and enable/disable still use `id`
as the query condition. This PR may have implications for recent changes in the
namespace feature. CC: @xcsnx
<!--
Thank you for proposing a pull request. This template will guide you through
the essential steps necessary for a pull request.
-->
Make sure that:
- [x] You have read the [contribution
guidelines](https://shenyu.apache.org/community/contributor-guide).
- [x] You submit test cases (unit or integration tests) that back your
changes.
- [x] Your local test passed `./mvnw clean install
-Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
