moremind commented on code in PR #49:
URL: 
https://github.com/apache/shenyu-client-golang/pull/49#discussion_r1849365939


##########
example/http_client/http_client.go:
##########
@@ -63,12 +64,13 @@ func main() {
                RPCType:     constants.RPCTYPE_HTTP, //require user provide
                Host:        "127.0.0.1",            //require user provide
                Port:        "8080",                 //require user provide
+               NamespaceId: "public",               //require user provide

Review Comment:
   the namespace is shenyu namespace default value



##########
example/http_client/http_client.go:
##########
@@ -48,12 +48,13 @@ func main() {
                Enabled:     true,                //require user provide
                Host:        "127.0.0.1",         //require user provide
                Port:        "8080",              //require user provide
+               NamespaceId: "public",            //require user provide

Review Comment:
   give default value for shenyu namespace id



##########
example/http_client/http_client.go:
##########
@@ -48,12 +48,13 @@ func main() {
                Enabled:     true,                //require user provide
                Host:        "127.0.0.1",         //require user provide
                Port:        "8080",              //require user provide
+               NamespaceId: "public",            //require user provide

Review Comment:
   649330b6-c2d7-4edc-be8e-8a54df9eb385



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to