po-168 commented on code in PR #5873:
URL: https://github.com/apache/shenyu/pull/5873#discussion_r1950587412
##########
shenyu-spring-boot-starter/shenyu-spring-boot-starter-client/shenyu-spring-boot-starter-client-common/src/main/java/org/apache/shenyu/springboot/starter/client/common/config/ShenyuClientCommonBeanConfiguration.java:
##########
@@ -73,7 +73,7 @@ public ShenyuClientConfig shenyuClientConfig() {
* @return the shenyu discovery config
*/
@Bean
- @ConditionalOnProperty(prefix = "shenyu.discovery", name = "enable",
matchIfMissing = false, havingValue = "true")
+ @ConditionalOnProperty(prefix = "shenyu.discovery", name = "enable",
havingValue = "true")
Review Comment:
> why remove this?
The default value is false. Does it matter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
