(shenyu) branch master updated: [type:fix] fix(admin): Ensure data consistency by adding @Transactional (#5992)

[hefengen]

This is an automated email from the ASF dual-hosted git repository.

hefengen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shenyu.git


The following commit(s) were added to refs/heads/master by this push:
     new 281a1a317b [type:fix] fix(admin): Ensure data consistency by adding 
@Transactional (#5992)
281a1a317b is described below

commit 281a1a317bc4fb713269c467d8d95eb0ce6f15c7
Author: yqw570994511 <49865334+yqw570994...@users.noreply.github.com>
AuthorDate: Mon Apr 7 14:17:04 2025 +0800

    [type:fix] fix(admin): Ensure data consistency by adding @Transactional 
(#5992)
    
    Co-authored-by: yuqianwei <qq120405>
    Co-authored-by: aias00 <liuhon...@apache.org>
---
 .../java/org/apache/shenyu/admin/service/impl/AppAuthServiceImpl.java   | 2 ++
 .../java/org/apache/shenyu/admin/service/impl/DiscoveryServiceImpl.java | 1 +
 .../java/org/apache/shenyu/admin/service/impl/MetaDataServiceImpl.java  | 1 +
 3 files changed, 4 insertions(+)

diff --git 
a/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/AppAuthServiceImpl.java
 
b/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/AppAuthServiceImpl.java
index 39f13ee5cd..73be2cb91e 100644
--- 
a/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/AppAuthServiceImpl.java
+++ 
b/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/AppAuthServiceImpl.java
@@ -140,6 +140,7 @@ public class AppAuthServiceImpl implements AppAuthService {
     }
 
     @Override
+    @Transactional(rollbackFor = Exception.class)
     public ShenyuAdminResult applyUpdate(final AuthApplyDTO authApplyDTO) {
         if (StringUtils.isAnyBlank(authApplyDTO.getAppKey(), 
authApplyDTO.getAppName())
                 || authApplyDTO.getOpen() && 
CollectionUtils.isEmpty(authApplyDTO.getPathList())) {
@@ -212,6 +213,7 @@ public class AppAuthServiceImpl implements AppAuthService {
     }
 
     @Override
+    @Transactional(rollbackFor = Exception.class)
     public ShenyuAdminResult updateDetailPath(final AuthPathWarpDTO 
authPathWarpDTO) {
         AppAuthDO appAuthDO = 
appAuthMapper.selectById(authPathWarpDTO.getId());
         if (Objects.isNull(appAuthDO)) {
diff --git 
a/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/DiscoveryServiceImpl.java
 
b/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/DiscoveryServiceImpl.java
index 9765c9577b..99bc75d6da 100644
--- 
a/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/DiscoveryServiceImpl.java
+++ 
b/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/DiscoveryServiceImpl.java
@@ -452,6 +452,7 @@ public class DiscoveryServiceImpl implements 
DiscoveryService {
     }
     
     @Override
+    @Transactional(rollbackFor = Exception.class)
     public ConfigImportResult importData(final String namespace, final 
List<DiscoveryDTO> discoveryList, final ConfigsImportContext context) {
         if (CollectionUtils.isEmpty(discoveryList)) {
             return ConfigImportResult.success();
diff --git 
a/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/MetaDataServiceImpl.java
 
b/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/MetaDataServiceImpl.java
index 75f20af13b..ae52536cb1 100644
--- 
a/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/MetaDataServiceImpl.java
+++ 
b/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/MetaDataServiceImpl.java
@@ -102,6 +102,7 @@ public class MetaDataServiceImpl implements MetaDataService 
{
     }
 
     @Override
+    @Transactional(rollbackFor = Exception.class)
     public String createOrUpdate(final MetaDataDTO metaDataDTO) {
         return StringUtils.isBlank(metaDataDTO.getId()) ? 
this.create(metaDataDTO) : this.update(metaDataDTO);
     }