Wweiei commented on code in PR #6147:
URL: https://github.com/apache/shenyu/pull/6147#discussion_r2342819550
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/model/vo/RuleVO.java:
##########
@@ -380,7 +380,7 @@ public static RuleVO buildRuleVO(final RuleDO ruleDO) {
*/
public static RuleVO buildRuleVO(final RuleDO ruleDO, final
List<RuleConditionVO> ruleConditions) {
return new RuleVO(ruleDO.getId(), ruleDO.getSelectorId(),
ruleDO.getMatchMode(), MatchModeEnum.getMatchModeByCode(ruleDO.getMatchMode()),
- ruleDO.getName(), ruleDO.getEnabled(), ruleDO.getLoged(),
ruleDO.getSort(), ruleDO.getHandle(),
+ ruleDO.getRuleName(), ruleDO.getEnabled(), ruleDO.getLoged(),
ruleDO.getSortCode(), ruleDO.getHandle(),
Review Comment:
There is already a public static RuleVO buildRuleVO(final RuleDO ruleDO)
method in RuleVO.If the condition is not available, just set it to null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
