Aias00 commented on code in PR #6162:
URL: https://github.com/apache/shenyu/pull/6162#discussion_r2354250478
##########
db/init/oracle/schema.sql:
##########
@@ -2528,7 +2528,7 @@ comment on column DISCOVERY.id
is 'primary key id';
comment on column DISCOVERY.name
is 'the discovery name';
-comment on column DISCOVERY.level
+comment on column DISCOVERY."level"
Review Comment:
no quotation marks
##########
db/init/oracle/schema.sql:
##########
@@ -2513,7 +2513,7 @@ create table discovery
(
id VARCHAR2(128) not null,
name VARCHAR2(255) not null,
- level VARCHAR2(64) not null,
+ "level" VARCHAR2(64) not null,
Review Comment:
no quotation marks, should change this field`s name such as descovery_level
##########
db/init/oracle/schema.sql:
##########
@@ -3068,34 +3068,34 @@ comment on column NAMESPACE_USER_REL.date_updated
is 'update time';
-INSERT /*+ IGNORE_ROW_ON_DUPKEY_INDEX(resource(id)) */ INTO resource (id,
parent_id, title, name, url, component, resource_type, sort, icon, is_leaf,
is_route, perms, status)
+INSERT /*+ IGNORE_ROW_ON_DUPKEY_INDEX(resource(id)) */ INTO "resource" (id,
parent_id, title, name, url, component, resource_type, sort, icon, is_leaf,
is_route, perms, status)
Review Comment:
is the table name must with quotation marks?
##########
db/init/oracle/schema.sql:
##########
@@ -3634,19 +3634,19 @@ COMMENT ON COLUMN registry_config.registry_group IS
'group';
COMMENT ON COLUMN registry_config.date_created IS 'create time';
COMMENT ON COLUMN registry_config.date_updated IS 'update time';
-INSERT /*+ IGNORE_ROW_ON_DUPKEY_INDEX(resource(id)) */ INTO resource (id,
parent_id, title, name, url, component, resource_type, sort, icon, is_leaf,
is_route, perms, status, date_created, date_updated)
-VALUES ('1953048313980116900', '1357956838021890048',
'SHENYU.MENU.SYSTEM.MANAGMENT.REGISTRY', 'registry', '/config/registry',
'registry', 1, 7, 'ordered-list', 0, 0, '', 1, '2025-08-06 17:00:00.000',
'2025-08-06 17:00:00.000');
-INSERT /*+ IGNORE_ROW_ON_DUPKEY_INDEX(resource(id)) */ INTO resource (id,
parent_id, title, name, url, component, resource_type, sort, icon, is_leaf,
is_route, perms, status, date_created, date_updated)
-VALUES ('1953048313980116901', '1953048313980116900',
'SHENYU.BUTTON.SYSTEM.ADD', '', '', '', 2, 0, '', 1, 0, 'system:registry:add',
1, '2025-08-06 17:00:00.000', '2025-08-06 17:00:00.000');
-INSERT /*+ IGNORE_ROW_ON_DUPKEY_INDEX(resource(id)) */ INTO resource (id,
parent_id, title, name, url, component, resource_type, sort, icon, is_leaf,
is_route, perms, status, date_created, date_updated)
-VALUES ('1953048313980116902', '1953048313980116900',
'SHENYU.BUTTON.SYSTEM.LIST', '', '', '', 2, 1, '', 1, 0,
'system:registry:list', 1, '2025-08-06 17:00:00.000', '2025-08-06
17:00:00.000');
-INSERT /*+ IGNORE_ROW_ON_DUPKEY_INDEX(resource(id)) */ INTO resource (id,
parent_id, title, name, url, component, resource_type, sort, icon, is_leaf,
is_route, perms, status, date_created, date_updated)
-VALUES ('1953048313980116903', '1953048313980116900',
'SHENYU.BUTTON.SYSTEM.DELETE', '', '', '', 2, 2, '', 1, 0,
'system:registry:delete', 1,'2025-08-06 17:00:00.000', '2025-08-06
17:00:00.000');
-INSERT /*+ IGNORE_ROW_ON_DUPKEY_INDEX(resource(id)) */ INTO resource (id,
parent_id, title, name, url, component, resource_type, sort, icon, is_leaf,
is_route, perms, status, date_created, date_updated)
-VALUES ('1953048313980116904', '1953048313980116900',
'SHENYU.BUTTON.SYSTEM.EDIT', '', '', '', 2, 3, '', 1, 0,
'system:registry:edit', 1, '2025-08-06 17:00:00.000', '2025-08-06
17:00:00.000');
-
-INSERT INTO permission (id, role_id, resource_id, date_created, date_updated)
VALUES ('1953049887387303901', '1346358560427216896', '1953048313980116900',
sysdate, sysdate);
-INSERT INTO permission (id, role_id, resource_id, date_created, date_updated)
VALUES ('1953049887387303902', '1346358560427216896', '1953048313980116901',
sysdate, sysdate);
-INSERT INTO permission (id, role_id, resource_id, date_created, date_updated)
VALUES ('1953049887387303903', '1346358560427216896', '1953048313980116902',
sysdate, sysdate);
-INSERT INTO permission (id, role_id, resource_id, date_created, date_updated)
VALUES ('1953049887387303904', '1346358560427216896', '1953048313980116903',
sysdate, sysdate);
-INSERT INTO permission (id, role_id, resource_id, date_created, date_updated)
VALUES ('1953049887387303905', '1346358560427216896', '1953048313980116904',
sysdate, sysdate);
\ No newline at end of file
+INSERT /*+ IGNORE_ROW_ON_DUPKEY_INDEX(resource(id)) */ INTO "resource" (id,
parent_id, title, name, url, component, resource_type, sort, icon, is_leaf,
is_route, perms, status, date_created, date_updated)
+VALUES ('1953048313980116900', '1357956838021890048',
'SHENYU.MENU.SYSTEM.MANAGMENT.REGISTRY', 'registry', '/config/registry',
'registry', 1, 7, 'ordered-list', 0, 0, '', 1, to_timestamp('2025-08-06
17:00:00.000', 'YYYY-MM-DD HH24:MI:SS.FF3'), to_timestamp('2025-08-06
17:00:00.000', 'YYYY-MM-DD HH24:MI:SS.FF3'));
Review Comment:
Are all oracle version support this method to_timestamp?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
