Copilot commented on code in PR #6309:
URL: https://github.com/apache/shenyu/pull/6309#discussion_r3008621238
##########
shenyu-kubernetes-controller/src/main/java/org/apache/shenyu/k8s/common/IngressConstants.java:
##########
@@ -81,31 +81,31 @@ public class IngressConstants {
// The configuration key to specify parameter types for the Dubbo plugin,
in string
public static final String PLUGIN_DUBBO_PARAMENT_TYPE =
"shenyu.apache.org/plugin-dubbo-parament-type";
- // The configuration key to specify the Tars path for the plugin, in string
+ // The configuration key to specify whether to use the Motan plugin, in
string
public static final String PLUGIN_MOTAN_ENABLED =
"shenyu.apache.org/plugin-motan-enabled";
- // The configuration key to specify the Tars path for the plugin, in string
+ // The configuration key to specify the Motan context path for the plugin,
in string
public static final String PLUGIN_MOTAN_CONTEXT_PATH =
"shenyu.apache.org/plugin-motan-context-path";
- // The configuration key to specify the Tars path for the plugin, in string
+ // The configuration key to specify the Motan app name for the plugin, in
string
public static final String PLUGIN_MOTAN_APP_NAME =
"shenyu.apache.org/plugin-motan-app-name";
- // The configuration key to specify the Tars method name for the plugin,
in string
+ // The configuration key to specify the Motan method name for the plugin,
in string
public static final String PLUGIN_MOTAN_METHOD_NAME =
"shenyu.apache.org/plugin-motan-method-name";
- // The configuration key to specify the Tars path for the plugin, in string
+ // The configuration key to specify the Motan path for the plugin, in
string
public static final String PLUGIN_MOTAN_PATH =
"shenyu.apache.org/plugin-motan-path";
- // The configuration key to specify the Tars service name for the plugin,
in string
+ // The configuration key to specify the Motan service name for the plugin,
in string
public static final String PLUGIN_MOTAN_SREVICE_NAME =
"shenyu.apache.org/plugin-motan-service-name";
Review Comment:
`PLUGIN_MOTAN_SREVICE_NAME` is misspelled ("SREVICE"). Since this constant
is used in `MotanIngressParser`, consider adding a correctly spelled alias
(e.g., `PLUGIN_MOTAN_SERVICE_NAME`) and migrating internal usages to it while
keeping the misspelled constant deprecated for backward compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
