wu-sheng commented on a change in pull request #1102: Add .NET/.NET Core 
components in component-libraries config
URL: 
https://github.com/apache/incubator-skywalking/pull/1102#discussion_r183236149
 
 

 ##########
 File path: 
apm-collector/apm-collector-boot/src/main/resources/component-libraries.yml
 ##########
 @@ -122,9 +122,30 @@ Jedis:
   languages: Java
 
 
+# .NET/.NET Core components
+AspNetCore:
+  id: 1001
 
 Review comment:
   I prefer to keep  [0, 3000) for Java and across language frameworks. So 
please use [3000, 4000) for C#/.NET only.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to