tuohai666 commented on a change in pull request #1934: Provide plugin for ShardingSphere URL: https://github.com/apache/incubator-skywalking/pull/1934#discussion_r234489247
########## File path: apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java ########## @@ -109,7 +111,7 @@ public static ComponentsDefine getInstance() { } public ComponentsDefine() { - components = new String[50]; + components = new String[100]; Review comment: I refer to ArrayList's scaling, double the size each time. It's ok if change it to 51 or another smaller one. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services