wu-sheng closed pull request #2147: Bugfix: logger information has not enough arguments URL: https://github.com/apache/incubator-skywalking/pull/2147
This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/service/EndpointInventoryRegister.java b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/service/EndpointInventoryRegister.java index d490b6c18b..f573f4f3e8 100644 --- a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/service/EndpointInventoryRegister.java +++ b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/service/EndpointInventoryRegister.java @@ -79,7 +79,7 @@ private EndpointInventoryCache getCacheService() { InventoryProcess.INSTANCE.in(endpointInventory); } else { - logger.warn("Endpoint {} heartbeat, but not found in storage."); + logger.warn("Endpoint {} heartbeat, but not found in storage.", endpointId); } } } diff --git a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/service/NetworkAddressInventoryRegister.java b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/service/NetworkAddressInventoryRegister.java index 0cff697d0a..18d05b200a 100644 --- a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/service/NetworkAddressInventoryRegister.java +++ b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/service/NetworkAddressInventoryRegister.java @@ -111,7 +111,7 @@ private IServiceInstanceInventoryRegister getServiceInstanceInventoryRegister() InventoryProcess.INSTANCE.in(networkAddress); } else { - logger.warn("Network getAddress {} heartbeat, but not found in storage."); + logger.warn("Network getAddress {} heartbeat, but not found in storage.", addressId); } } diff --git a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/service/ServiceInventoryRegister.java b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/service/ServiceInventoryRegister.java index d5a94df191..04b60dba76 100644 --- a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/service/ServiceInventoryRegister.java +++ b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/service/ServiceInventoryRegister.java @@ -96,7 +96,7 @@ private ServiceInventoryCache getServiceInventoryCache() { InventoryProcess.INSTANCE.in(serviceInventory); } else { - logger.warn("Service {} heartbeat, but not found in storage."); + logger.warn("Service {} heartbeat, but not found in storage.", serviceId); } } @@ -109,7 +109,7 @@ private ServiceInventoryCache getServiceInventoryCache() { InventoryProcess.INSTANCE.in(serviceInventory); } else { - logger.warn("Service {} mapping update, but not found in storage."); + logger.warn("Service {} mapping update, but not found in storage.", serviceId); } } } ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services