mrproliu commented on a change in pull request #5915:
URL: https://github.com/apache/skywalking/pull/5915#discussion_r532025739
##########
File path:
oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -233,12 +234,29 @@ public SampleFamily tag(Closure<?> cl) {
}).toArray(Sample[]::new));
}
+ /**
+ * Ignore histogram decrease bucket value, at agent side meter, need to
ignore decrease histogram bucket value
+ */
+ public SampleFamily ignoreHistogramDecrease() {
+ this.context.ignoreHistogramDecrease = true;
+ return this;
+ }
+
+ /**
+ * Change default histogram bucket value unit,
+ * use second on the Prometheus, use millisecond on the meter side meter
+ */
+ public SampleFamily defaultHistogramBucketUnit(TimeUnit unit) {
Review comment:
Have created `SampleFactoryBuilder` to help create `SampleFactory` with
these two settings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
