vcjmhg commented on a change in pull request #6003:
URL: https://github.com/apache/skywalking/pull/6003#discussion_r546327651
##########
File path: test/plugin/pom.xml
##########
@@ -99,6 +103,151 @@
<encoding>${project.build.sourceEncoding}</encoding>
</configuration>
</plugin>
+ <plugin>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <version>${maven-checkstyle-plugin.version}</version>
+ <configuration>
+
<configLocation>${maven.multiModuleProjectDirectory}/apm-checkstyle/checkStyle.xml</configLocation>
+
<headerLocation>${maven.multiModuleProjectDirectory}/apm-checkstyle/CHECKSTYLE_HEAD</headerLocation>
+ <encoding>UTF-8</encoding>
+ <consoleOutput>true</consoleOutput>
+
<includeTestSourceDirectory>true</includeTestSourceDirectory>
+
<failOnViolation>${checkstyle.fails.on.error}</failOnViolation>
+ <sourceDirectories>
+
<sourceDirectory>${project.build.sourceDirectory}</sourceDirectory>
Review comment:
There are some problems that should be considered, if we write the
scripts into `run.sh`:
1. We execute scenarios in a different order and the content of pom.xml may
be different, which breaks idempotence and may cause conflicts when merging.
2. Some scenarios may need to be handled separately to check the code style.
For example `jdk14-with-gson-scenario` cannot be checked by adding its name in
`plugin/pom.xml` because of different jdk version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
