ascrutae commented on a change in pull request #2292: mysql-8x-plugin and
multihost support for mysql5.x
URL:
https://github.com/apache/incubator-skywalking/pull/2292#discussion_r264194315
##########
File path:
apm-sniffer/apm-sdk-plugin/mysql-6.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/v6/define/FailoverConnectionProxyInstrumentation.java
##########
@@ -54,4 +53,9 @@
protected ClassMatch enhanceClass() {
return byName(INTERCEPT_CLASS);
}
+
+ @Override
+ protected String[] witnessClasses() {
Review comment:
I advise that this method should remove. because this method had implemented
in its parent class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
