dsc6636926 commented on a change in pull request #2292: mysql-8x-plugin and
multihost support for mysql5.x
URL:
https://github.com/apache/incubator-skywalking/pull/2292#discussion_r264222706
##########
File path:
apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/v5/define/AbstractConnectionInstrumentation.java
##########
@@ -41,7 +40,7 @@
*
* @author zhangxin
*/
-public abstract class ConnectionInstrumentation extends
ClassInstanceMethodsEnhancePluginDefine {
+public abstract class AbstractConnectionInstrumentation extends
AbstractMysqlInstrumentation {
Review comment:
this class extends ``AbstractMysqlInstrumentation`` class witch has
implement ``witnessClasses`` method, and the subclass
``Mysql50ConnectionInstrumentation`` has different witnessClass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
