wu-sheng commented on a change in pull request #2300: [WIP]Customize Enhance code of plugin URL: https://github.com/apache/incubator-skywalking/pull/2300#discussion_r264500560
########## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java ########## @@ -164,4 +167,16 @@ public static boolean TRACE_DSL = false; } } + + public static class Customize { + /** + * Custom enhancement class configuration file path, recommended to use an absolute path. + */ + public static String ENHANCE_FILE = ""; + + /** + * Some information after custom enhancements, this configuration is used by the custom enhancement plugin. + */ + public static Map<String, Object> CONTEXT = new HashMap<String, Object>(); Review comment: The reason you put the CONTEXT here, is this for avoiding classloader isolation issue? If SO, add this to comments. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services