BFergerson commented on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-473479322 @wu-sheng, using the new asynchronous functionality I'm able to get the following results:  This appears correct to me but I'm able to achieve these results without creating local spans and without using `ContextSnapshot`. I simply call `prepareForAsync` at the beginning of the request and `asyncFinish` at the end of the request. Same situation with the response. This produces the results above with the single exit span and single entry span. Is that you meant for it to be used? Previously you said that the callback was supposed to be a new local span. Is that still the case when using the asynchronous functionality? If so, what is the order of events I should be taking. First open the local span, then close the entry span via `asyncFinish` then close the local span?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
