wu-sheng commented on a change in pull request #43: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/43#discussion_r557355118
########## File path: agent-dynamic-configuration/AgentDynamicConfiguration.proto ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +syntax = "proto3"; + +option java_multiple_files = true; +option java_package = "org.apache.skywalking.apm.network.agent.dynamic.configuration.v3"; +option csharp_namespace = "SkyWalking.NetworkProtocol"; +option go_package = "skywalking/network/agent/configuration/v3"; + +import "common/Common.proto"; + +// Query current service dynamic configuration items from OAP. Review comment: ```suggestion // Fetch the latest dynamic configurations of the service. ``` ########## File path: agent-dynamic-configuration/AgentDynamicConfiguration.proto ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +syntax = "proto3"; + +option java_multiple_files = true; +option java_package = "org.apache.skywalking.apm.network.agent.dynamic.configuration.v3"; +option csharp_namespace = "SkyWalking.NetworkProtocol"; +option go_package = "skywalking/network/agent/configuration/v3"; + +import "common/Common.proto"; + +// Query current service dynamic configuration items from OAP. +service AgentDynamicConfigurationService { Review comment: ```suggestion service ConfigurationDiscoveryService { ``` Very similar naming rule like Envoy's xDS ########## File path: agent-dynamic-configuration/AgentDynamicConfiguration.proto ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +syntax = "proto3"; + +option java_multiple_files = true; +option java_package = "org.apache.skywalking.apm.network.agent.dynamic.configuration.v3"; +option csharp_namespace = "SkyWalking.NetworkProtocol"; +option go_package = "skywalking/network/agent/configuration/v3"; + +import "common/Common.proto"; + +// Query current service dynamic configuration items from OAP. +service AgentDynamicConfigurationService { + rpc getAgentDynamicConfiguration (AgentDynamicConfigurationRequest) returns (Commands) { Review comment: ```suggestion rpc fetchConfigurations (ConfigurationSyncRequest) returns (Commands) { ``` ########## File path: agent-dynamic-configuration/AgentDynamicConfiguration.proto ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +syntax = "proto3"; + +option java_multiple_files = true; +option java_package = "org.apache.skywalking.apm.network.agent.dynamic.configuration.v3"; +option csharp_namespace = "SkyWalking.NetworkProtocol"; +option go_package = "skywalking/network/agent/configuration/v3"; + +import "common/Common.proto"; + +// Query current service dynamic configuration items from OAP. Review comment: Also, we need more documents to describe what the Command should look like. And how UUID system works. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
