wu-sheng commented on a change in pull request #6220: URL: https://github.com/apache/skywalking/pull/6220#discussion_r559085569
########## File path: oap-server/server-receiver-plugin/configuration-discovery-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/recevier/configuration/discovery/ConfigurationDiscoveryProvider.java ########## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.oap.server.recevier.configuration.discovery; + +import java.io.FileNotFoundException; +import java.io.Reader; +import org.apache.skywalking.oap.server.configuration.api.ConfigurationModule; +import org.apache.skywalking.oap.server.configuration.api.DynamicConfigurationService; +import org.apache.skywalking.oap.server.core.CoreModule; +import org.apache.skywalking.oap.server.core.server.GRPCHandlerRegister; +import org.apache.skywalking.oap.server.library.module.ModuleConfig; +import org.apache.skywalking.oap.server.library.module.ModuleDefine; +import org.apache.skywalking.oap.server.library.module.ModuleProvider; +import org.apache.skywalking.oap.server.library.module.ModuleStartException; +import org.apache.skywalking.oap.server.library.module.ServiceNotProvidedException; +import org.apache.skywalking.oap.server.library.util.ResourceUtils; +import org.apache.skywalking.oap.server.receiver.sharing.server.SharingServerModule; +import org.apache.skywalking.oap.server.recevier.configuration.discovery.handler.grpc.ConfigurationDiscoveryServiceHandler; + +public class ConfigurationDiscoveryProvider extends ModuleProvider { + + private ConfigurationDiscoveryRulesWatcher configurationDiscoveryRulesWatcher; + + @Override + public String name() { + return "default"; + } + + @Override + public Class<? extends ModuleDefine> module() { + return ConfigurationDiscoveryModule.class; + } + + @Override + public ModuleConfig createConfigBeanIfAbsent() { + return new EmptySettings(); + } + + @Override + public void prepare() throws ServiceNotProvidedException, ModuleStartException { + Reader applicationReader; + try { + applicationReader = ResourceUtils.read("agent-dynamic-config.yml"); + } catch (FileNotFoundException e) { + throw new ModuleStartException("can't load agent-dynamic-config.yml", e); + } Review comment: Why read a static file? If users are using the static files, why don't they use the `agent.config` directly? I don't think we should provide this mechanism. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
