BFergerson commented on issue #2386: Vert.x Core 3.x Plugin URL: https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-475834936 @wu-sheng, why do you think it will be hard to tell whether or not to make an exit span vs a local span? I'm able to detect whether the message is going over the wire or being routed locally pretty easily. If it's going over the wire I use `ContextCarrier` and if it's not I use `ContextSnapshot`. I'm a bit confused on how I should be handling the local routing scenario. For an example scenario, let's say I have a local message flow of: `A` -> `B` -> `C` (where `A` sends a message to `B` and so on) and that in turn triggers a response flow of: `C` -> `B` -> `A` (where `C` responds to `B` and so on). In this scenario, do I create any entry or exit spans or are they all supposed to be local? Your question about what I set the peer to set me down this path. Technically there wouldn't be a peer here because it's just communicating with itself. So should I just be creating a local spans? If the answer is yes, would the process be: - create async local span when `A` calls `B` - create local span when `B` receives message from `A` (call continued with `A` context) - create async local span when `B` calls `C` - create local span when `C` receives message from `B` (call continued with `B` context) - close async local span when `C` responds to `B` - close async local span when `B` responds to `A` I think I've got the over the wire scenario covered. It's the simple: - create exit span when sending messages - create entry span when receiving messages
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
