EvanLjp commented on a change in pull request #6249:
URL: https://github.com/apache/skywalking/pull/6249#discussion_r563309271
##########
File path:
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/base/StorageEsInstaller.java
##########
@@ -135,17 +155,19 @@ protected void createTable(Model model) throws
StorageException {
String matchCName =
MatchCNameBuilder.INSTANCE.build(columnDefine.getColumnName().getName());
Map<String, Object> originalColumn = new HashMap<>();
- originalColumn.put("type",
columnTypeEsMapping.transform(columnDefine.getType(),
columnDefine.getGenericType()));
+ originalColumn.put(
+ "type",
columnTypeEsMapping.transform(columnDefine.getType(),
columnDefine.getGenericType()));
originalColumn.put("copy_to", matchCName);
properties.put(columnDefine.getColumnName().getName(),
originalColumn);
Map<String, Object> matchColumn = new HashMap<>();
matchColumn.put("type", "text");
- matchColumn.put("analyzer", "oap_analyzer");
+ matchColumn.put("analyzer",
columnDefine.getAnalyzer().name().toLowerCase());
Review comment:
fixed
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/Column.java
##########
@@ -62,17 +62,16 @@
* @return the length of this column, this is only for {@link String}
column. The usage of this depends on the
* storage implementation.
*
- * Notice, different lengths may cause different types.
- * Such as, over 16383 would make the type in MySQL to be MEDIUMTEXT, due
to database varchar max=16383
- *
+ * Notice, different lengths may cause different types. Such as, over
16383 would make the type in MySQL to be
+ * MEDIUMTEXT, due to database varchar max=16383
* @since 7.1.0
*/
int length() default 200;
/**
* The return name of system environment could provide an override value
of the length limitation.
- * @return the variable name of system environment.
*
+ * @return the variable name of system environment.
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
