kezhenxu94 commented on pull request #6304:
URL: https://github.com/apache/skywalking/pull/6304#issuecomment-772134409
> > I’m +1 to add this, what I meant was we still need to find some other
methods to enforce this.
>
> Does current checkStyle change enforce this?
Not really. The added rule will only fail the CI if the method actually
overrides its parent’s method, AND is commented (JavaDoc) with `/**
{@inheritDoc} */’, this doesn’t make sense at all b/c we seldom use that
JavaDoc and if you add that JavaDoc, why will you forget to add `@Override`.
>
> > It says it only checks this method commented with /** {@inheritdoc} */
because checkstyle is static analyzer, it cannot see a class’s parent class
when analyzing, hence doesn’t know whether the method is overriding its
parent’s method
>
> What does this mean to `@Override`? I read the missing `@Override` could
cause CI failure in the style check plugin doc. I am not sure I am following.
See 👆。
I approve the code changes in this PR (add the missing `@Override`), but
this rule only take very limited effects, does no harm though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
