wu-sheng commented on issue #2506: Fix issue 2473 URL: https://github.com/apache/skywalking/pull/2506#issuecomment-485410125 @zhaoyuguang I have talked with @ascrutae There are two things 1. This issue has been fixed already, not elegant, but work. 1. Your change will work(I think), but you don't change `#buildJunction`, which affect the byte-buddy core. 1. Change `HierarchyMatch` makes the API more complex, I have doubts and concerns about the meaning of doing it. Because of (1), we have the method to fix. Also, in current plugins, we haven't found anything else requires this. So, I suggest abandoning the change this time, and wait to see. @ascrutae supports me about this.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
