kezhenxu94 commented on a change in pull request #6403:
URL: https://github.com/apache/skywalking/pull/6403#discussion_r579626990
##########
File path: .github/actions/e2e-test/action.yml
##########
@@ -53,6 +53,11 @@ runs:
- name: Run E2E Test
shell: bash
run: |
+ echo "::group::Install SNAPSHOT apm-application-toolkit"
+ ./mvnw -DskipTests -N install
+ ./mvnw -f apm-application-toolkit -DskipTests -am install
+ echo "::endgroup::"
Review comment:
> How? Our release process doesn't do this automatically.
Automation may be not a restriction IMO because there is only [one
place](https://github.com/apache/skywalking/blob/6c6a8a7109c9a5a0dc173d8424ce45dec1da9f9e/test/e2e/e2e-service-provider/pom.xml#L37)
to update. Also, forgetting to update it can be discovered (fail the CI) early
when PR is opened, instead of failing someday after the newer version is
released (we had this before), also we don't bother to release SNAPSHOTs just
for testing. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]