wu-sheng commented on a change in pull request #6427:
URL: https://github.com/apache/skywalking/pull/6427#discussion_r581154264
##########
File path:
oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -175,7 +176,10 @@ public SampleFamily min(List<String> by) {
}
public SampleFamily avg(List<String> by) {
- ExpressionParsingContext.get().ifPresent(ctx ->
ctx.aggregationLabels.addAll(by));
+ ExpressionParsingContext.get().ifPresent(ctx -> {
+ ctx.aggregationLabels.addAll(by);
+ ctx.downsampling = DownsamplingType.AVG;
Review comment:
Including several other methods. The codes mixed Tuple, it is hard to
read.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
