tom-pytel opened a new pull request #36: URL: https://github.com/apache/skywalking-nodejs/pull/36
The changes here are the result of preparing for allowing Exit/Exit and Entry/Entry parent child relationships during which I discovered and am in the process of fixing and improving some async functionality. The source of the problem which necessitated #27 was discovered and fixed. The `http` and `axios` modules did not properly `async()` on returning a connection. Also, `async()` itself now duplicates the spans list for the current task in order that async tasks created before the `async()` don't have their copies of the list corrupted by subsequent operations in the current task. This all removes the necessity for a separate `invalid` flag, which flag itself was only a partial patch for the main problem which would still manifest in other ways. The functionality of the `http` module is also being expanded so that errors on `'data'` events are properly attributed to the span. Not for merge just yet. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
