wu-sheng commented on a change in pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#discussion_r588228796
##########
File path:
oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -477,7 +523,7 @@ static RunningContext instance() {
.build();
}
- MeterEntity meterEntity;
+ private Map<MeterEntity, Sample[]> meterSamples;
Review comment:
This could be never initialized, if there is no
`service`/`instance`/`endpoint` called. Then could cause NPE in the Analyzer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
