wu-sheng commented on a change in pull request #6499: URL: https://github.com/apache/skywalking/pull/6499#discussion_r588900634
########## File path: oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/base/PhysicalIndices.java ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.oap.server.storage.plugin.elasticsearch.base; + +import java.util.Map; +import java.util.Optional; +import java.util.concurrent.ConcurrentHashMap; + +public class PhysicalIndices { Review comment: I think your latest change still separating `PhysicalIndexManager and PhysicalIndices` as `PhysicalIndices` and `PhysicalIndexer`. Could you explain why? And again on coding style, you have `PhysicalIndexer` having all instance level methods, but actually no instance field, and at the same time, you have PhysicalIndices with a static field, with all static methods. These 2 typically should be reverted. No instance method means no point to maintain the instance. Why? Please read my above suggestion. If you want a enum to provide an API set, it is fine, but please keep consistent. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
