kezhenxu94 commented on pull request #45: URL: https://github.com/apache/skywalking-client-js/pull/45#issuecomment-793326885
> @kezhenxu94 @wu-sheng @Fine0830 > > Is there any progress on this patch? Sorry that this PR hasn't been merged for a little long because it seems that we haven't yet reached to a consensus whether we should allowlist / blocklist. To reiterate, I'm +1 to allowlisting, the critical reason is that: 1. Websites are revolving, new (existing) 3rd-party domains may be added (changed) without advance notice, `blocklist` will cause those requests failed, while `allowlist` may only miss some traces when new controllable domains are added. 2. Adopting `blocklist` and using exclusive match with regex to allowlist some domains is counter-intuitive and error-prone, which is unnecessary if we know users are highly possible to configure in `allowlist` way. @tianyk please give the community a little more time to evaluate and reach to a consensus (hopefully) so that we don't make something unreasonable for the users, :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
