wu-sheng commented on a change in pull request #6499:
URL: https://github.com/apache/skywalking/pull/6499#discussion_r591581350
##########
File path:
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/StorageModuleElasticsearchProvider.java
##########
@@ -246,4 +250,11 @@ public String convert(final String indexName) {
return indexName;
}
}
+
+ private static class SkyWalkingTagConverter implements IndexNameConverter {
+ @Override
+ public String convert(final String indexName) {
+ return "sw" + "_" + indexName;
+ }
+ }
Review comment:
We just need to use `sw` as the default namespace, please set it in the
`#prepare` method. We don't need to add this new converter. And more
importantly, this name is super confusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
