hanahmily commented on a change in pull request #67:
URL: 
https://github.com/apache/skywalking-kubernetes/pull/67#discussion_r599650725



##########
File path: chart/skywalking/values.yaml
##########
@@ -97,6 +97,7 @@ ui:
     # clusterIP: None
     externalPort: 80
     internalPort: 8080
+    nodePort: 30080

Review comment:
       nodePort seems a default value to the port number once the service type 
is `NodePort`, but`service.type` determines the service type, defaulting to 
`ClusterIP`. 
   
   and I prefer to use ingress to expose UI service, let's set 
`ingress.enabled` to `true`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to