wallezhang commented on a change in pull request #6774:
URL: https://github.com/apache/skywalking/pull/6774#discussion_r616337902
##########
File path:
test/plugin/scenarios/pulsar-scenario/src/main/java/test/apache/skywalking/apm/testcase/pulsar/controller/CaseController.java
##########
@@ -51,38 +51,37 @@ public String pulsarCase() throws PulsarClientException,
InterruptedException {
String topic = "test";
+ CountDownLatch latch = new CountDownLatch(1);
+
PulsarClient pulsarClient =
PulsarClient.builder().serviceUrl(PULSAR_DOMAIN + serviceUrl).build();
Producer<byte[]> producer =
pulsarClient.newProducer().topic(topic).create();
- Consumer<byte[]> consumer =
pulsarClient.newConsumer().topic(topic).subscriptionName("test").subscribe();
+ Consumer<byte[]> consumer = pulsarClient.newConsumer().topic(topic)
Review comment:
Yes, because the `receive()` method will be called first before entering
the `MessageListener` callback, so I directly replace the old one, and I think
this can cover all cases in the test. I just add new expect data in
`expectedData.yml` and reserve the `receive()` method segment. So based on this
consideration, do I still need to create a new consumer to cover the new case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
