kezhenxu94 commented on a change in pull request #6727: URL: https://github.com/apache/skywalking/pull/6727#discussion_r627396656
########## File path: docs/en/setup/envoy/als_setting.md ########## @@ -29,8 +29,9 @@ On Istio version 1.6.0+, if Istio is installed with [`demo` profile](https://ist - Activate SkyWalking [Envoy Receiver](../backend/backend-receivers.md). This is activated by default. -- Choose an ALS analyzer. There are two available analyzers, `k8s-mesh` and `mx-mesh`. - Set the system environment variable **SW_ENVOY_METRIC_ALS_HTTP_ANALYSIS** such as `SW_ENVOY_METRIC_ALS_HTTP_ANALYSIS=k8s-mesh` +- Choose an ALS analyzer. There are two available analyzers, `k8s-mesh` and `mx-mesh` for both HTTP access logs and TCP access logs. + Set the system environment variable **SW_ENVOY_METRIC_ALS_HTTP_ANALYSIS** and **SW_ENVOY_METRIC_ALS_TCP_ANALYSIS** + such as `SW_ENVOY_METRIC_ALS_HTTP_ANALYSIS=k8s-mesh`, `SW_ENVOY_METRIC_ALS_TCP_ANALYSIS=k8s-mesh` Review comment: > meta exchange works in HTTP 1/2 due to the HTTP 1/2 has a header to propagate the metadata transparently. I remember in the Istio doc, I shared with you, it says, using some mTLS field to do that, but whether it is implemented? I think you need another round of testing to confirm, we can't be sure. According to the tests result (I’ve added tcp topology verification with mongodb enabled in the test env), it seems to passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
