lujiajing1126 commented on pull request #2: URL: https://github.com/apache/skywalking-banyandb/pull/2#issuecomment-847696572
As we discussed this morning, the following changes are applied, - Add type system to `Pair`, so now we have `StrPair` and `IntPair` - Simplify `Entity`: move `duration`, `trace_id` to fields since these names should be defined in a Schema. - Remove `count` in response: we do not have statistics so far. - Add `projection` to select key names. - Rename `EntityCriteria`. - Add `offset` with `limit` to support paging scenario. - Also move `duration`, `trace_id` to fields which are indexed and add comments. Besides, I suppose `Range` operation is vague: it is not clear for inclusive or exclusive at the edges. What's your opinion? Any other suggestion is welcome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
