wu-sheng commented on a change in pull request #7039:
URL: https://github.com/apache/skywalking/pull/7039#discussion_r642149316
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsStreamProcessor.java
##########
@@ -199,4 +203,20 @@ private MetricsPersistentWorker
downSamplingWorker(ModuleDefineHolder moduleDefi
return persistentWorker;
}
+
+ // todo javadoc
+ public void remove(ModuleManager manager, String metricName, Class<?
extends Metrics> metricsClass) {
Review comment:
Tip, we need to check whether the worker would be GC successfully to
avoid potential OOM risk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
