wu-sheng commented on a change in pull request #43:
URL:
https://github.com/apache/skywalking-satellite/pull/43#discussion_r644552403
##########
File path: Makefile
##########
@@ -54,15 +54,6 @@ tools:
deps: tools
$(GO_GET) -v -t -d ./...
-.PHONY: gen-codes
-gen-codes:
- $(PROTOC) --version || sh tools/install_protoc.sh
- /bin/sh tools/protocol_gen.sh
-
-.PHONY: gen-docs
-gen-docs: build
- rm -rf $(PLUGIN_DOC_DIR)
- $(OUT_DIR)/$(BINARY)-$(VERSION)-$(OSNAME)-$(ARCH) docs
--output=$(PLUGIN_DOC_DIR)
Review comment:
One file wouldn't be able to be removed, satellite has its own event
proto. But we should remove most of others, and host the generated source codes
directly to avoid the complexity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
