wu-sheng commented on a change in pull request #7069:
URL: https://github.com/apache/skywalking/pull/7069#discussion_r647906778



##########
File path: 
apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java
##########
@@ -151,6 +152,7 @@ public static void premain(String agentArgs, 
Instrumentation instrumentation) th
                                                 final TypeDescription 
typeDescription,
                                                 final ClassLoader classLoader,
                                                 final JavaModule module) {
+            JVMUtil.getCurrentClassloaderList().add(classLoader);

Review comment:
       1. `JVMUtil` should be renamed to `LoadedLibraryCollector`
   2. `getCurrentClassloaderList().add` should be changed as 
`registerClassLoader`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to