wu-sheng edited a comment on issue #7113:
URL: https://github.com/apache/skywalking/issues/7113#issuecomment-860008718


   @BFergerson Codes like 
`RequestMappingMethodInterceptor#getAcceptedMethodTypes`, I think we need some 
adjustment, to follow the same name pattern like this
   
   
https://github.com/apache/skywalking/blob/efcb396f7338265f0b1e05f1a512dcd65773c538/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java#L129-L136
   
   Meaning, remove `<` and `>`.
   
   Also, I think we need to discuss whether we should keep runtime HTTP method 
rather than declaration level methods, only the latter could be multiple values.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to