wu-sheng commented on a change in pull request #7179:
URL: https://github.com/apache/skywalking/pull/7179#discussion_r659171868
##########
File path:
apm-sniffer/apm-sdk-plugin/grpc-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/grpc/v1/server/TracingServerCallListener.java
##########
@@ -101,4 +96,18 @@ public void onHalfClose() {
ContextManager.stopSpan();
}
}
+
+ @Override
+ public void onComplete() {
+ super.onComplete();
+ ContextManager.stopSpan();
Review comment:
I agree that, `onComplete` or `onError` should be the right place to
finish span. Only concern is about across threads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
